Ticket #48 (new 개선사항)
Opened 3 years ago
Fix for segfault on disabling the NateOn account
| Reported by: | matt | Owned by: | |
|---|---|---|---|
| Priority: | 매우낮음 | Milestone: | |
| Version: | 2.3.1 | Keywords: | segfault, dissable |
| Cc: |
Description
I've made 3 changes to the source of the NateOn? plugin.
1. I have removed one segfault due to a null in nateon.c. The fix is essentially checking if the variable is null, and if it is; skiping the crashing code. To reproduce the fault: a. open a NateOn? conversation. b. disable the nateon account associated with the conversation. c. segfault.
2. Altered the "Signed in from elsewhere" warning in session.c. Originally it used a generic error warning, now it uses the specific "Signed in from elsewhere" type error, so Pidgin handles them together (eg I sign in on MSN and NateOn? on another computer, the 2 warnings are joined into one signed in elsewhere warning). Please see the screen-shot for a better explanation.
3. Memo Dialogue The "Send Memo" dialogue is untitled and looks untidy in the task-bar. I've added in an English title in nateon.c. It needs a Korean translation adding in too in the ko.po file.
I know very little about C, so any help or advice is welcome.
Attachments
-
MattsModsMin.diff
(2.3 KB) - added by matt
3 years ago.
- Patch file for my changes
-
SignedInElseWhere.jpg
(8.4 KB) - added by matt
3 years ago.
- Screenshot for change 32
